[WPE] WPE Platform: handle multiple next presentation update callbacks#44931
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom May 6, 2025
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 51a4f1b) Details |
nikolaszimmermann
approved these changes
May 6, 2025
spenap
reviewed
May 6, 2025
carlosgcampos
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=292533 Reviewed by Nikolas Zimmermann. We currently have a limit of 1, but some layout tests end up calling callAfterNextPresentationUpdate before the previous one is completed, so we can just handle multiple callbacks like gtk port does. * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.cpp: (WKWPE::ViewPlatform::~ViewPlatform): (WKWPE::ViewPlatform::dispatchPendingNextPresentationUpdateCallbacks): (WKWPE::ViewPlatform::callAfterNextPresentationUpdate): * Source/WebKit/UIProcess/API/wpe/WPEWebViewPlatform.h: Canonical link: https://commits.webkit.org/294553@main
webkit-commit-queue
force-pushed
the
wpe-platform-multiple-next-update-cbs
branch
from
51a4f1b to
48d151b
Compare
Collaborator
|
Committed 294553@main (48d151b): https://commits.webkit.org/294553@main Reviewed commits have been landed. Closing PR #44931 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
48d151b
51a4f1b